Security should not reload files that haven't changed #50207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvernum
reviewed
Dec 16, 2019
.../security/src/main/java/org/elasticsearch/xpack/security/authc/file/FileUserPasswdStore.java
Outdated
Show resolved
Hide resolved
...rity/src/test/java/org/elasticsearch/xpack/security/authc/file/FileUserPasswdStoreTests.java
Show resolved
Hide resolved
|
@elasticmachine OK to test |
tvernum
added
:Security/Security
|
Pinging @elastic/es-security (:Security/Security) |
|
Fixed. Please take a look. |
albertzaharovits
approved these changes
Dec 29, 2019
There was a problem hiding this comment.
Thank you for your contribution @J-Bean !
LGTM
We should still wait for Tim to take another pass.
|
@elasticmachine update branch |
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Jan 8, 2020
In security we currently monitor a set of files for changes: - config/role_mapping.yml (or alternative configured path) - config/roles.yml - config/users - config/users_roles This commit prevents unnecessary reloading when the file change actually doesn't change the internal structure. Backport of: elastic#50207 Co-authored-by: Anton Shuvaev <anton.shuvaev91@gmail.com>
tvernum
added a commit
that referenced
this pull request
Jan 8, 2020
In security we currently monitor a set of files for changes: - config/role_mapping.yml (or alternative configured path) - config/roles.yml - config/users - config/users_roles This commit prevents unnecessary reloading when the file change actually doesn't change the internal structure. Backport of: #50207 Co-authored-by: Anton Shuvaev <anton.shuvaev91@gmail.com>
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
In security we currently monitor a set of files for changes: - config/role_mapping.yml (or alternative configured path) - config/roles.yml - config/users - config/users_roles This commit prevents unnecessary reloading when the file change actually doesn't change the internal structure. Closes: elastic#50063 Co-authored-by: Anton Shuvaev <anton.shuvaev91@gmail.com>
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In security we currently monitor a set of files for changes:
This commit prevents unnecessary reloading when the file change actually doesn't change the internal structure.
closes #50063